Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Purge v1 #142

Merged
merged 1 commit into from
Feb 20, 2025
Merged

chore: Purge v1 #142

merged 1 commit into from
Feb 20, 2025

Conversation

gselzer
Copy link
Collaborator

@gselzer gselzer commented Feb 20, 2025

This PR removes the original NDV application, and I believe that now is the right time to remove it because:

  • With the merge of feat: Rectangular ROIs #114 we should now be at feature parity
  • Tests specific to v1 are now failing in feat: rgb, v2 #141, meaning it will take active maintenance to maintain. While I haven't gotten to the bottom of these failures, I can't reproduce them easily either.

What do you think, @tlambert03?

@gselzer gselzer added the bug Something isn't working label Feb 20, 2025
@gselzer gselzer requested a review from tlambert03 February 20, 2025 23:32
@gselzer gselzer self-assigned this Feb 20, 2025
@tlambert03 tlambert03 marked this pull request as ready for review February 20, 2025 23:33
@tlambert03
Copy link
Member

Kill it :)

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.35%. Comparing base (b393238) to head (2963522).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   79.23%   80.35%   +1.11%     
==========================================
  Files          51       44       -7     
  Lines        5172     4112    -1060     
==========================================
- Hits         4098     3304     -794     
+ Misses       1074      808     -266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gselzer gselzer merged commit 0f7b61c into pyapp-kit:main Feb 20, 2025
48 of 51 checks passed
@gselzer gselzer deleted the purge-v1 branch February 20, 2025 23:40
@tlambert03 tlambert03 changed the title Purge v1 chore: Purge v1 Feb 24, 2025
@tlambert03 tlambert03 added refactor and removed bug Something isn't working labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants