feat: return 3d support to v2 #83
Conversation
…ambert03/ndv into v2-bases-instead-of-protocols
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 71.83% 71.71% -0.12%
==========================================
Files 43 43
Lines 4328 4430 +102
==========================================
+ Hits 3109 3177 +68
- Misses 1219 1253 +34 ☔ View full report in Codecov by Sentry. |
|
ok @gselzer, this now does the thing I wanted it to (as far as the end user is concerned). I didn't do too much stuff to have to make it work (though I did pass |
| @@ -40,6 +40,8 @@ def __post_init__(self) -> None: | |||
| self.dtype = self.data.dtype | |||
|
|
|||
|
|
|||
| # NOTE: nobody particularly likes this class. It does important stuff, but we're | |||
|
One small thing I noticed while testing - the histogram doesn't update when you go to 3D. If you bring this
I can definitely live with it in the short term if it gets things working, since everything you changed is private API, no? |
reopening #71 against main.
This adds back 3D (volume) views, with support for all gui frontends.
Currently, it just adds a "3D" button, which asks the DataWrapper to guess at which the next spatial ("Z") dimension is. But the api has the view tell the model what the new "visible axes" are; this leaves open the possibility in a later PR that the GUI will have more ability to select exactly which axes are used when showing a 3D view. (but that's for a later PR)