fix: remove texture guessing for vispy, try texture_format='auto' before falling back #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the "look before you leap" logic for creating an openGL context and checking whether float textures are supported before using
texture_format='auto'
on vispy. Instead, it just tries to use'auto'
and falls back to CPU-backed textures if it fails.The reason is that some tests have been failing periodically for wxPython (emitting a warning from the CPUScaled texture). Looking into those test errors made me realize that wx was never using GPU scaled textures on vispy, and that was presumably due to an error in the output
supports_float_textures
in a wx context. Rather than try to fix that, it think it's better to just try to use a gpu-texture, and let vispy error and fallback to CPU