Merge branch 'main' into resuable

pyapp-kit · Nov 6, 2023 · 1f10e32 · 1f10e32
2 parents 50c9fdb + f47fd68
commit 1f10e32
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -15,30 +15,30 @@ repos:
         stages: [commit-msg]
 
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v4.5.0
     hooks:
       - id: check-docstring-first
       - id: end-of-file-fixer
       - id: trailing-whitespace
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.0.292
+    rev: v0.1.4
     hooks:
       - id: ruff
-        args: [--fix]
+        args: [--fix, --unsafe-fixes]
 
   - repo: https://github.com/psf/black
-    rev: 23.9.1
+    rev: 23.10.1
     hooks:
       - id: black
 
   - repo: https://github.com/abravalheri/validate-pyproject
-    rev: v0.14
+    rev: v0.15
     hooks:
       - id: validate-pyproject
 
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.5.1
+    rev: v1.6.1
     hooks:
       - id: mypy
         exclude: tests|_throttler.pyi

diff --git a/src/psygnal/_group_descriptor.py b/src/psygnal/_group_descriptor.py
@@ -423,8 +423,7 @@ def __get__(
 
             # clean up the cache when the instance is deleted
             with contextlib.suppress(TypeError):
-                # mypy says too many attributes for weakref.finalize, but it's wrong.
-                weakref.finalize(instance, self._instance_map.pop, obj_id, None)  # type: ignore [call-arg]
+                weakref.finalize(instance, self._instance_map.pop, obj_id, None)
 
         return self._instance_map[obj_id]