Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EventedModel docs and errors to refer field_dependencies #335

Conversation

sjdemartini
Copy link
Contributor

property_dependencies was renamed to field_dependencies in #234 but some associated error messages and docs still refer to the deprecated name.

`property_dependencies` was renamed to `field_dependencies` in pyapp-kit#234 but some associated error messages and docs still refer to the deprecated name.
Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #335 will not alter performance

Comparing sjdemartini:update-eventedmodel-field_dependencies-docs (abe278e) with main (6d5b644)

Summary

✅ 67 untouched benchmarks

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6d5b644) to head (abe278e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #335   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2076      2076           
=========================================
  Hits          2076      2076           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thank you!

@tlambert03 tlambert03 merged commit 37bd312 into pyapp-kit:main Nov 8, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants