Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique artifact names #4015

Merged

Conversation

agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented Apr 17, 2024

Description

Addresses one out of two parts of issue #3489 – resolves artifacts names and how they are downloaded to fix the rule GH104 Use unique names for upload-artifact. They are now all downloaded in one folder for the benchmarks and the wheel builder workflows.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Apr 17, 2024

Triggered a workflow run on my fork to ensure everything works: https://github.com/agriyakhetarpal/PyBaMM/actions/runs/8715941402 (edit: nevermind, the PyPI publishing job won't run on forks). I think it should be safe to merge, though. The Windows failures from Chocolatey are unrelated.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (cf09d5e) to head (d2d3bae).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4015   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          257      257           
  Lines        21249    21249           
========================================
  Hits         21161    21161           
  Misses          88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @agriyakhetarpal! Looks good to me!

@agriyakhetarpal agriyakhetarpal merged commit b0bc5cf into pybamm-team:develop Apr 17, 2024
39 of 40 checks passed
@agriyakhetarpal agriyakhetarpal deleted the unique-artifact-names branch April 17, 2024 11:33
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this pull request Aug 12, 2024
* pybamm-team#3489 Use unique artifact names for all jobs

* Limit benchmarks results to PyBaMM repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants