…v24.5

This reverts commit e25db2a.

`max_number_steps` -> `max_num_steps` to match casadi

Co-authored-by: Eric G. Kratz <[email protected]>

Co-authored-by: Eric G. Kratz <[email protected]>

This reverts commit e25db2a.

`max_number_steps` -> `max_num_steps` to match casadi

Co-authored-by: Eric G. Kratz <[email protected]>

Co-authored-by: Eric G. Kratz <[email protected]>

… into idaklu-options

…ner/PyBaMM into idaklu-options"

This reverts commit 37b1973, reversing
changes made to b01db78.

* Update test pypi

* Style fix

…#4209)

* Make function for handling time or reuse an existing one
Fixes pybamm-team#4113

* style: pre-commit fixes

* fixing raises RegEx Error Experiment Test

* fix pre-commit error

* Update pybamm/callbacks.py

Co-authored-by: Eric G. Kratz <[email protected]>

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <[email protected]>
Co-authored-by: Valentin Sulzer <[email protected]>
Co-authored-by: Eric G. Kratz <[email protected]>

* make longer default duration and calculate it for C-rate

* add tests

* typo

* pybamm-team#4224 add warning for time termination and add abs

* fix tests

* pybamm-team#4224 keep non-C-rate default at 24h for performance reasons

* trying to fix experiment

* fix example

* pybamm-team#4224 eric comments

* fix bug

Co-authored-by: Eric G. Kratz <[email protected]>

* Fix CodeCov GHA workflow failure (pybamm-team#3845)

This amends the tag for the CodeCov GitHub Action from `4.1.0` to `v4.1.0`. This was a Dependabot error

* Begin refactor IDAKLU solver to support generalisable expressions [i.e. support more than just casadi functions]

* Continue refactor; compiles but with dlopen error on load; committing to test on another machine

* Refactor: Introduce Expression and ExpressionSet classes

* Restructure Expressions with generics folder and implementation-specific subfolders

* Separate Expression classes

* Template Expression class

* WIP: Subclass expressions (remove templates in order to generalise execution framework)

* Subclass expressions and remove unnecessary template arguments

* Isolate casadi functionality to Expression subclasses

* Add IREE expressions class

* Remove breakpoints

* Map input arguments to (reduced) call signature in MLIR

* Add support for inputs

* Support sensitivities

* Pre-commit

* Support output_variables

* Fix designator order error on linux; remove reference to ninja

* OS-invariant library loading

* Convert some pointer arrays to vectors; fixes sporadic crashes

* Fix bad memory allocations

* Tidy-up code

* Tidy up code

* Resolve jax/iree version numbers

* Conditional compilation of iree code

* Fix compiler variables

* Update noxfile sources list

* Pre-commit

* Make IREE tests conditional on IREE install

* Enable IREE in CI unit/integration testing

* Make demotion optional in idaklu_solver.py (still unsupported by IDAKLU)

* style: pre-commit fixes

* Fix expression tree test given change to bracketed expressions

* Codacy corrections and suppressions

* Enable IREE in unit testing

* style: pre-commit fixes

* Enable IREE in coverage testing

* Restrict IREE install to supported MacOS/Python versions

* Restrict IREE supported macOS installs

* Additional tests for IREE (demotion, output_variables, sensititivies)

* style: pre-commit fixes

* Additional tests (improve test coverage)

* Fix IREE unit test

* Fix sensitivities-sparsity bug; improve tests

* Fix tests

* Improve coverage

* Improve coverage (indirect)

* Suppress IREE warning on reload

* style: pre-commit fixes

* Fix codacy warning

* Fix noxfile docstring

* Update noxfile.py

Co-authored-by: Agriya Khetarpal <[email protected]>

* Update pyproject.toml

Co-authored-by: Agriya Khetarpal <[email protected]>

* style: pre-commit fixes

* Update pybamm/solvers/c_solvers/idaklu.cpp

Co-authored-by: Martin Robinson <[email protected]>

* Update pybamm/solvers/c_solvers/idaklu/Expressions/IREE/IREEFunctions.cpp

Co-authored-by: Martin Robinson <[email protected]>

* Try removing no-cover from expression_tree/function.py

* Remove C from class name

* Clarify Base Expression docstrings

* Remove build-time iree.compiler search in CMakeLists.txt

* Add install note to iree-compiler in pyproject.toml

* Add IREE dependencies to docs

* style: pre-commit fixes

* Refactor MLIR parsing into ModuleParser class

* style: pre-commit fixes

* Add codacy hints

* Codacy fix

* Remove no-cover statements

* style: pre-commit fixes

* Coverage fix

---------

Co-authored-by: Ferran Brosa Planella <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <[email protected]>
Co-authored-by: Martin Robinson <[email protected]>

Co-authored-by: Eric G. Kratz <[email protected]>

pybamm-team#4268)

Bumps the actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action).


Updates `github/codeql-action` from 3.25.11 to 3.25.12
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@b611370...4fa2a79)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.5.1 → v0.5.2](astral-sh/ruff-pre-commit@v0.5.1...v0.5.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Moving a bunch of unit tests to pytest

Signed-off-by: Pradyot Ranjan <[email protected]>

* style: pre-commit fixes

* style fix

Signed-off-by: Pradyot Ranjan <[email protected]>

* Update tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_mpm_half_cell.py

Co-authored-by: Agriya Khetarpal <[email protected]>

* Update tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_spm.py

Co-authored-by: Agriya Khetarpal <[email protected]>

* Update tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_spme.py

Co-authored-by: Agriya Khetarpal <[email protected]>

* Update tests/unit/test_parameters/test_parameter_sets_class.py

Co-authored-by: Agriya Khetarpal <[email protected]>

* Update tests/unit/test_parameters/test_parameter_sets_class.py

Co-authored-by: Agriya Khetarpal <[email protected]>

* Update tests/unit/test_plotting/test_plot.py

Co-authored-by: Agriya Khetarpal <[email protected]>

* adding skips

Signed-off-by: Pradyot Ranjan <[email protected]>

* Update tests/unit/test_plotting/test_plot.py

Co-authored-by: Agriya Khetarpal <[email protected]>

* adding reason for skips

Signed-off-by: Pradyot Ranjan <[email protected]>

---------

Signed-off-by: Pradyot Ranjan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <[email protected]>

* Using tempfile for standard_model_test

Signed-off-by: Pradyot Ranjan <[email protected]>

* style: pre-commit fixes

---------

Signed-off-by: Pradyot Ranjan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Release v24.5rc2

…bamm-team#4163)

* fix degradation options when one of the phases has no degradation

* skip Newman Tobias test

---------

Co-authored-by: Eric G. Kratz <[email protected]>
Co-authored-by: Arjun Verma <[email protected]>

…#4236)

* Removing flase flagging of assert statements from tests

Signed-off-by: Pradyot Ranjan <[email protected]>

* style: pre-commit fixes

* Using ruff to check for asserts

Signed-off-by: Pradyot Ranjan <[email protected]>

* Using TypeError instead of assert

Signed-off-by: Pradyot Ranjan <[email protected]>

* Adding back bandit file

Signed-off-by: Pradyot Ranjan <[email protected]>

* style: pre-commit fixes

* Adding tests

Signed-off-by: Pradyot Ranjan <[email protected]>

---------

Signed-off-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <[email protected]>

This reverts commit e25db2a.

`max_number_steps` -> `max_num_steps` to match casadi

Co-authored-by: Eric G. Kratz <[email protected]>

Co-authored-by: Eric G. Kratz <[email protected]>