Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replacing rounded faraday constant with exact value in bpx.py #4290

Merged
merged 10 commits into from
Jul 31, 2024
Merged

replacing rounded faraday constant with exact value in bpx.py #4290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3925509
updated faraday constant to exact value in bpx.py
dion-w Jul 24, 2024
12136ff
Update CHANGELOG.md
dion-w Jul 24, 2024
68d62d0
Update CHANGELOG.md
dion-w Jul 24, 2024
fd10517
Update CHANGELOG.md
dion-w Jul 24, 2024
77971a0
Update pybamm/parameters/bpx.py
dion-w Jul 30, 2024
d4d2168
Merge branch 'develop' into patch-2
dion-w Jul 30, 2024
d989dfe
Update CHANGELOG.md
dion-w Jul 30, 2024
afeced9
Merge branch 'develop' into patch-2
kratman Jul 30, 2024
9fdf03e
Merge branch 'develop' into patch-2
arjxn-py Jul 31, 2024
ffb465a
Merge branch 'develop' into patch-2
kratman Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# [Unreleased](https://github.com/pybamm-team/PyBaMM/)

- Replaced rounded faraday constant with its exact value in `bpx.py` for better comparison between different tools

## Features

- Added additional user-configurable options to the (`IDAKLUSolver`) and adjusted the default values to improve performance. ([#4282](https://github.com/pybamm-team/PyBaMM/pull/4282))
Expand Down
2 changes: 1 addition & 1 deletion pybamm/parameters/bpx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def _entropic_change(sto, c_s_max, dUdT, constant=False):
# (cs-cs_max)) in BPX exchange current is defined j0 = F * k_norm * sqrt((ce/ce0) *
# (cs/cs_max) * (1-cs/cs_max))
c_e = pybamm_dict["Initial concentration in electrolyte [mol.m-3]"]
F = 96485
F = pybamm.constants.F.value

def _exchange_current_density(c_e, c_s_surf, c_s_max, T, k_ref, Ea):
return (
Expand Down
Loading