Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot voltage components for composite electrodes #4435

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mleot
Copy link
Contributor

@mleot mleot commented Sep 12, 2024

Description

The goal here is to allow for plotting of overpotential components in a composite electrode. Attempting to do so first in a composite half-cell

Fixes #4434

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@agriyakhetarpal agriyakhetarpal changed the title Plot-voltage-components-for-composite-electrodes Plot voltage components for composite electrodes Sep 12, 2024
@DrSOKane
Copy link
Contributor

DrSOKane commented Oct 2, 2024

I added a Chen2020_composite parameter set as part of PR #4463, which may be useful for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot Voltage Components for Composite Electrodes
2 participants