-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Download IDAKLU from pybammsolvers #4487
base: develop
Are you sure you want to change the base?
Conversation
A new link error cropped up, but it looks like we could get a lot of savings on time with this update. Edit: Most of the run time appears to be in the integration tests, so unfortunately the time savings are not as good as I would have hoped. |
The linkage error is the same one as #3783, coming from CasADi's plugin system. I am not sure if it's worth fixing it, since it was fixed by @martinjrobins for the linear interpolant case by dropping down to Python but IIRC there wasn't a way in CasADi for doing it for the cubic |
@agriyakhetarpal Yeah I was looking at that issue as well. As far as I can tell CasADI sets a path for plugins. I am trying to see if there is a decent workaround since this was part of #4464 My guess is that the wheels for the next release will be broken as well, but I have not confirmed it yet |
There is a workaround for Linux and macOS, but not for Windows (different toolchain); sadly, it's not decent enough to include. I think I'll raise a PR upstream in CasADi to get one part of the linkage going and see if we can migrate to a non-MSVC toolchain (which can potentially help provide that workaround for this on Windows later on). It's been on my list of things to do for a while, but I've yet to do it. |
This is fixed locally with this: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4487 +/- ##
===========================================
- Coverage 99.41% 98.82% -0.60%
===========================================
Files 293 293
Lines 22554 22548 -6
===========================================
- Hits 22423 22282 -141
- Misses 131 266 +135 ☔ View full report in Codecov by Sentry. |
Yes, won't work with Windows |
Description
This will separate the IDAKLU C++ code from pybamm.
Type of change
This should speed up CI by skipping the build of the C++ code.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: