-
-
Notifications
You must be signed in to change notification settings - Fork 622
chore: enable isort ruff rule and apply fixes #5003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5003 +/- ##
===========================================
- Coverage 98.57% 98.57% -0.01%
===========================================
Files 304 304
Lines 23661 23655 -6
===========================================
- Hits 23325 23319 -6
Misses 336 336 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @Aswinr24, could you please resolve the merge conflicts here? Thanks! Also, as this is a linting-only change and performs no changes in functionality, we should leave the commit hash for the changes in the What can be done here is:
Here is an article that should serve as helpful reading: https://graphite.dev/guides/git-blame-ignore-revs We can then merge the PR (not squash-merge, but a regular merge). |
Since this is just changing the order of the import statements, we can probably skip the ignore-revs part |
I'm not sure I follow – changing the order of the import statements is a style-only change and is not useful at all in the git blame, i.e., it rather provides a reason to add it to the ignore-revs file instead of not doing so? |
Thanks! Yes, will resolve the merge conflicts and do the necessary changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was deleted in #4996
Can you remove this version of it and re-do the rebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes with formatting changes like these, the best approach is to hard reset to the base branch, then re-apply the pre-commit. It is safer than merging and squashing since that modifies history
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure will fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A file was mistakenly re-added. This was caught by the docs tests
Description
This PR enables additional Ruff linting rules and applies fixes to the codebase as suggested by Ruff. The changes include:
Enabling I (isort) rule in pyproject.toml.
fixes issues raised by ruff linter which included:
Related to #4925
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commit
nox -s tests
nox -s doctests