Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deep rework (mostly ci and build system) #46

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Jan 16, 2025

deep rework (mostly ci and build system)

Fix

CMake

  • Bump CMake minimal version to 3.18 to align with pybind11_protobuf and needed to work with pypa/manylinux image (ed need Development.Module option in FindPython3)
  • rename status as status_py_extension_stub target to avoid conflict with abseil-cpp when fetched (ed cmake target are NOT scoped)

    note: still provide the pybind11_abseil::status target alias.
  • Disable C++ gnu extension.
  • Rework third party management
    • disable test for dependencies BUT still allow to enable them for pybind11_abseil
    • Bump abseil-cpp from 20230802.0 to 20240722.0
    • Bump pybind11 from master(floating) to v2.13.6
  • Fix XCode build using MODULE in pybind_extension
  • Fix Python support by not linking against the python library as manylinux images and PEP-513 require

    ref: https://peps.python.org/pep-0513/#libpythonx-y-so-1

Bazel

  • Update dependencies in MODULE.bazel and WORKSPACE
    • Bump Protobuf to v29.2
  • Add a .bazelignore to avoid to parse cmake's usual build directory
  • Add a .bazelrc with default options (similar to the one in pybind11_protobuf)

Update CI workflows

  • Split CMake and Bazel workflows to get independent badges
  • Split MacOS (amd64 and M1) and Windows (amd64) and Linux (amd64) jobs
  • import ubuntu-build.yml from pybind11_protobuf

Bazel

  • Add C++14, c++17 and c++20 flavours
  • Add -c opt and -c dbg variants
  • only test against the default python3.11

CMake

  • Test Python 3.9, 3.10. 3.11, 3.12
  • cmake(linux): Test Unix Makefile and Ninja Build generators
  • cmake(macOS): Test XCode and Makefile generators
  • cmake(windows): Test MSVC (VC 2022) generator

@copybara-service copybara-service bot force-pushed the test_715743424 branch 11 times, most recently from 3c2c9be to 3328187 Compare January 20, 2025 15:39
@copybara-service copybara-service bot changed the title Update CI workflows # Fix Jan 20, 2025
@copybara-service copybara-service bot changed the title # Fix deep rework (mostly ci and build system) Jan 20, 2025
@copybara-service copybara-service bot force-pushed the test_715743424 branch 2 times, most recently from 88f8d83 to 4a53218 Compare January 31, 2025 16:05
@copybara-service copybara-service bot closed this Jan 31, 2025
@copybara-service copybara-service bot deleted the test_715743424 branch January 31, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants