Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created a register path test while working on previous PR
and noticed odd behaviour, described in issue #379
this new test influences test behaviour of unrelated tests
in py2 and py3
a test that should fail or be skipped, does not run
This came to my attention while working on pathlib deregister support #384 .
The deregister path test stopped running when adding this new binary string test.
The test is not skipped, and did not fail, it inexplicably wasn't picked up by nose.
When removing the new test commited in this PR it worked again.
we can see this reflected in the logs https://ci.appveyor.com/project/mottosso/pyblish/builds/42230403/job/oefioqph7sbsnbqn
pathlib deregister test does not run
issue when using binary string to register plugin paths
in py 3
binary string fails in py3+
register the following path
results in failed test
AssertionError: b'c:\some\special\s\xc3\xb6d\xc3\xa4r\testpath' not in ['C:\\projects\\pyblish\\pyblish\\plugins', 'server\\plugins', b'c:\\some\\special\\s\xc3\xb6d\xc3\xa4r\testpath']
see old PR #383 for more info