New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor plugin validation #386

Open

hannesdelbeke wants to merge 1 commit into pyblish:master from hannesdelbeke:refactor/plugin-validation

Contributor

hannesdelbeke commented Jan 17, 2022

move duplicate code regarding plugin validation,
from plugins_from_module and register_plugin, into plugin_is_valid

refactor only no new code.

swapped
continue -> return False
raise Exception -> return False

depending on where plugin_is_valid is used we then raise an exception or debug log anyway, so logic remains same.

now there's no more dupe code for plugin validation, and it's all in the place where we expect it: the plugin_is_valid function


          move duplicate code regarding plugin validation into the plugin valid…

f384502

…ation function

Contributor Author

hannesdelbeke commented Jan 17, 2022

this should be ready for merge if we are happy with this

hannesdelbeke mentioned this pull request

refactor suggestion #382

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet