Skip to content

Commit

Permalink
Merge pull request #304 from pybop-team/302-reduce-integation-test-su…
Browse files Browse the repository at this point in the history
…ite-time

Decrease test suite completion time
  • Loading branch information
BradyPlanden authored May 9, 2024
2 parents 7825f1a + 682fe61 commit 0395429
Show file tree
Hide file tree
Showing 20 changed files with 2,803 additions and 5,396 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/test_on_push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest, macos-14]
os: [ubuntu-latest, windows-latest, macos-13, macos-14]
python-version: ["3.12"]

name: Integration tests (${{ matrix.os }} / Python ${{ matrix.python-version }})
Expand All @@ -60,8 +60,8 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest, macos-13, macos-14]
python-version: ["3.9", "3.10", "3.11", "3.12"]
exclude: # We run the coverage tests on Ubuntu with Python 3.12
- os: ubuntu-latest
exclude: # We run the coverage tests on macos-14 with Python 3.12
- os: macos-14
python-version: "3.12"

name: Unit tests (${{ matrix.os }} / Python ${{ matrix.python-version }})
Expand All @@ -86,7 +86,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest, macos-14]
os: [ubuntu-latest, windows-latest, macos-13, macos-14]
python-version: ["3.12"]

name: Test examples (${{ matrix.os }} / Python ${{ matrix.python-version }})
Expand All @@ -105,13 +105,13 @@ jobs:
run: |
nox -s examples
# Runs only on Ubuntu with Python 3.12
# Runs only on macos-14 with Python 3.12
check_coverage:
needs: style
runs-on: ubuntu-latest
runs-on: macos-14
strategy:
fail-fast: false
name: Coverage tests (ubuntu-latest / Python 3.12)
name: Coverage tests (macos-14 / Python 3.12)

steps:
- name: Check out PyBOP repository
Expand All @@ -127,7 +127,7 @@ jobs:
- name: Install dependencies
run: python -m pip install --upgrade pip nox[uv]

- name: Run coverage tests for Ubuntu with Python 3.12 and generate report
- name: Run coverage tests for macos-14 with Python 3.12 and generate report
run: nox -s coverage

- name: Upload coverage report
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Features

- [#304](https://github.com/pybop-team/PyBOP/pull/304) - Decreases the testing suite completion time.
- [#301](https://github.com/pybop-team/PyBOP/pull/301) - Updates default echem solver to "fast with events" mode.
- [#251](https://github.com/pybop-team/PyBOP/pull/251) - Increment PyBaMM > v23.5, remove redundant tests within integration tests, increment citation version, fix examples with incorrect model definitions.
- [#285](https://github.com/pybop-team/PyBOP/pull/285) - Drop support for Python 3.8.
Expand Down
2 changes: 1 addition & 1 deletion examples/notebooks/equivalent_circuit_identification.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@
"outputs": [],
"source": [
"sigma = 0.001\n",
"t_eval = np.arange(0, 900, 2)\n",
"t_eval = np.arange(0, 900, 3)\n",
"values = model.predict(t_eval=t_eval)\n",
"corrupt_values = values[\"Voltage [V]\"].data + np.random.normal(0, sigma, len(t_eval))\n",
"\n",
Expand Down
Loading

0 comments on commit 0395429

Please sign in to comment.