Skip to content

Commit

Permalink
Restore default_parameter_values
Browse files Browse the repository at this point in the history
  • Loading branch information
NicolaCourtier committed Jul 17, 2024
1 parent 21d87d3 commit 2581a2e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion pybop/models/empirical/base_ecm.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,9 @@ def __init__(
super().__init__(name=name, parameter_set=parameter_set)

# Set parameters, using either the provided ones or the default
self.default_parameter_values = self.pybamm_model.default_parameter_values
self._parameter_set = (
self._parameter_set or self.pybamm_model.default_parameter_values.copy()
self._parameter_set or self.default_parameter_values.copy()
)

# Define model geometry and discretization
Expand Down
3 changes: 2 additions & 1 deletion pybop/models/lithium_ion/base_echem.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@ def __init__(
self._unprocessed_model = self.pybamm_model

# Set parameters, using either the provided ones or the default
self.default_parameter_values = self.pybamm_model.default_parameter_values
self._parameter_set = (
self._parameter_set or self.pybamm_model.default_parameter_values.copy()
self._parameter_set or self.default_parameter_values.copy()
)

# Define model geometry and discretization
Expand Down

0 comments on commit 2581a2e

Please sign in to comment.