Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Move BPX to an optional dependency on the PyBOP #498

Closed
Dibyendu-IITKGP opened this issue Sep 12, 2024 · 0 comments · Fixed by #499
Closed

[Bug]: Move BPX to an optional dependency on the PyBOP #498

Dibyendu-IITKGP opened this issue Sep 12, 2024 · 0 comments · Fixed by #499
Assignees
Labels
bug Something isn't working

Comments

@Dibyendu-IITKGP
Copy link
Contributor

Python Version

Python 3.10.12

Describe the bug

BPX 0.4.0 requires Pydantic<2. This causes conflict when I am trying to use Battery-Data_Toolkit.

Steps to reproduce the behaviour

When an user wants to use Battery Data Toolkit (BDT) with PyBOP, using any library of BDT will throw an error. For example:

%pip install battery-data-toolkit
%pip install --upgrade pip ipywidgets -q
%pip install pybop -q
%pip install openpyxl
%pip install pandas --upgrade

from batdata.data import BatteryDataset
import plotly.graph_objects as go
import plotly.offline as pyo
import numpy as np

data_path = r"../data/cycler_data/batch_B12A_cell_2.h5" # set a suitable path for a H5 data
dataset = BatteryDataset.from_batdata_hdf(data_path)

---- This will cause an error.

Relevant log output

No response

@Dibyendu-IITKGP Dibyendu-IITKGP added the bug Something isn't working label Sep 12, 2024
@Dibyendu-IITKGP Dibyendu-IITKGP self-assigned this Sep 12, 2024
@Dibyendu-IITKGP Dibyendu-IITKGP linked a pull request Sep 12, 2024 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant