-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to likelihoods, bug fix GaussianLogLikelihood
class
#338
Conversation
…t values, updt non-bounded parameter logic, bugfix pints.CMAES construction
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #338 +/- ##
===========================================
+ Coverage 97.60% 97.72% +0.12%
===========================================
Files 42 42
Lines 2459 2502 +43
===========================================
+ Hits 2400 2445 +45
+ Misses 59 57 -2 ☔ View full report in Codecov by Sentry. |
…ss likelihoods, move MAP
GaussLogLikelihood
classGaussianLogLikelihood
class
…hood, aligns tests
…dd default and arg for parameter boundary multiplier, adds tests
Hi @BradyPlanden, thanks for working on this issue! I have tried adding |
Co-authored-by: Brady Planden <[email protected]>
Co-authored-by: Brady Planden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks @BradyPlanden! I left a few small comments but the implementation looks good overall.
Description
GaussianLogLikelihood
for use with all optimisers,GaussianLogLikelihood
to integration testing,CMAES
construction wherex0
is destroyed.MAP
to _likelihoods.pyIssue reference
Fixes #257
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.