-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors OptimisationResult class, adds finite cost check for identified parameters #527
Open
BradyPlanden
wants to merge
10
commits into
develop
Choose a base branch
from
526-add-optimisation-check-for-non-finite-cost-parameter-value
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactors OptimisationResult class, adds finite cost check for identified parameters #527
BradyPlanden
wants to merge
10
commits into
develop
from
526-add-optimisation-check-for-non-finite-cost-parameter-value
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n() object return, adds isfinite() check on optimisation results
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #527 +/- ##
========================================
Coverage 99.05% 99.05%
========================================
Files 52 52
Lines 3582 3583 +1
========================================
+ Hits 3548 3549 +1
Misses 34 34 ☔ View full report in Codecov by Sentry. |
…-cost-parameter-value
BradyPlanden
force-pushed
the
526-add-optimisation-check-for-non-finite-cost-parameter-value
branch
from
October 4, 2024 09:10
bac2447
to
a966997
Compare
…nin integration parametrisation, set sigma0 with BaseOptimiser default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BaseOptimisers
result method,Issue reference
Fixes #526
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.