Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use github hosted arm runners in ci #951

Merged
merged 1 commit into from
Jan 18, 2025
Merged

use github hosted arm runners in ci #951

merged 1 commit into from
Jan 18, 2025

Conversation

alex
Copy link
Member

@alex alex commented Jan 16, 2025

No description provided.

@alex
Copy link
Member Author

alex commented Jan 16, 2025

@ngoldbaum not sure what's going on here, but the 3.13t jobs just started failing?

@ngoldbaum
Copy link
Contributor

I haven't seen this. Yesterday it seemed to work: https://github.com/pyca/bcrypt/actions/runs/12793166231/job/35665350309#step:7:17. I'm not sure what changed.

@ngoldbaum
Copy link
Contributor

I guess this is tox-dev/tox#3391. I'll raise this internally as something we need to fix.

@alex
Copy link
Member Author

alex commented Jan 16, 2025

New virtualenv release happened yesterday, that's my first guess?

@ngoldbaum
Copy link
Contributor

Make sense! I think if we use --discover that should fix things: https://tox.wiki/en/4.21.2/cli_interface.html#tox-run---discover. Want me to send in a PR? Happy to do that today.

@alex
Copy link
Member Author

alex commented Jan 16, 2025

Yeah, https://virtualenv.pypa.io/en/latest/changelog.html#v20-29-0-2025-01-15 seems to confirm.

A PR fixing this would be much appreciated! (Also maybe we should switch to nox, as we did for cryptography.)

@reaperhulk reaperhulk merged commit 0f486e0 into main Jan 18, 2025
30 checks passed
@alex alex deleted the alex-patch-1 branch January 18, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants