Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use mutable argument defaults #11422

Closed
wants to merge 1 commit into from

Conversation

DimitriPapadopoulos
Copy link
Contributor

@alex
Copy link
Member

alex commented Aug 12, 2024

a) Mono-causality is, in fact, the root of all evil.
b) All the objects in question here are immutable, these various list attributes are never mutated. Therefore this PR does not improve safety.

As a result, thank you for the contribution, but we're not going to merge this.

@alex alex closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants