Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes to force .rst files to LF line endings #1001

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikewadsten
Copy link

setup.py runs a regex which assumes LF line endings
over the contents of CHANGELOG.rst.
When installing pyopenssl from source (pip install git+...)
on Windows, there's a good chance these files will be checked
out with CRLF line endings today, which leads to:

AttributeError: 'NoneType' object has no attribute 'group'

We could also address this by having the read_file
function in setup.py enforce LF line endings.
I think changing codecs.open to just open
would do it, since the default behavior of
universal newlines would be to translate to LF.

setup.py runs a regex which assumes LF line endings
over the contents of CHANGELOG.rst.
When installing pyopenssl from source (`pip install git+...`)
on Windows, there's a good chance these files will be checked
out with CRLF line endings today.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant