Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix X509Extension __str__() method for unknow extension types #1239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ich199
Copy link

@ich199 ich199 commented Aug 10, 2023

fixes: #1238
fixes: #270

Unsure if it would be preferred to use 65536 instead of 1 << 16 when defining X509V3_EXT_ERROR_UNKNOWN, but I copied the syntax used in OpenSSL

@ich199 ich199 force-pushed the fix-x509extension-str branch 2 times, most recently from fbce364 to 2f5b78d Compare August 10, 2023 14:23
@ich199
Copy link
Author

ich199 commented Aug 10, 2023

tests seem to be failing due to #1240

@ich199
Copy link
Author

ich199 commented Sep 1, 2023

tests are now failing due to an issue in a new release of sphinx (7.2.5) sphinx-doc/sphinx#11662

@mhils
Copy link
Member

mhils commented Sep 5, 2023

Thanks @ich199! The change generally makes sense to me. Would you mind adding a X509V3_EXT_ERROR_UNKNOWN binding to cryptography and then use this here instead of defining a custom constant?

@ich199
Copy link
Author

ich199 commented Sep 7, 2023

Thanks @mhils, I've created the binding in cryptography as requested and that's been merged. I'm guessing it would be preferred to backport that to 41.0.x rather than bumping the cryptography requirement here?

@mhils
Copy link
Member

mhils commented Sep 8, 2023

Awesome, thanks! Bumping the cryptography requirement here is perfectly fine (and preferred), cryptography and pyOpenSSL releases go more or less in tandem. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

X509Extension __str__() method raises exception for unknown extension types Crypto fail on SCT retrieval
2 participants