Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change empty CRL get_revoked to empty tuple #859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thecubic
Copy link

resolves remaining issue in #258 by switching empty get_revoked return to effective empty tuple.

This was breaking functional tests in a pyOpenSSL integration.

@reaperhulk
Copy link
Member

Ugh, how did we miss reviewing this for so long. I'm concerned about changing this because while it obviously makes more sense, this has been like this for 7 years now so presumably there are people out there depending on the None behavior.

Base automatically changed from master to main February 13, 2021 17:50
@reaperhulk
Copy link
Member

@thecubic after an almost comically long period of time I think we can merge this is if you can add a changelog entry noting this and linking to this PR (in backwards incompatible changes please).

@reaperhulk reaperhulk added this to the 21.0.0 milestone Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants