Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass plot_kwargs to ValidationCurve #3747

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morenobonaventura
Copy link

@morenobonaventura morenobonaventura commented Sep 22, 2023

  • pass plot_kwargs to ValidationCurve()
  • explicitly set param_name and param_range if they are included in plot_kwargs

Related Issue or bug

#3746

Info about Issue or bug
Closes #3746

Describe the changes you've made

  • pass plot_kwargs to ValidationCurve()
  • explicitly set param_name and param_range if they are included in plot_kwargs

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Just tested locally

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
Validation Curve
Validation Curve

- pass plot_kwargs to ValidationCurve
- explitily set `param_name` and `param_range` if they are included in plot_kwargs
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Yard1
Copy link
Member

Yard1 commented Sep 23, 2023

@morenobonaventura can you fix CI issues? Thanks!

Copy link

Stale pull request message: This PR will be automatically closed by GitHub Actions in 1 week if there is no further activity.

@morenobonaventura
Copy link
Author

@morenobonaventura can you fix CI issues? Thanks!

@Yard1, I can't see any CI set up in this github repo.
are there any automatic build/tests run on github actions or something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: plot_kwargs not passed to yellowbrick visualizers in function plot_model()
3 participants