Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: code refactoring and bug fixing #29

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Conversation

InzGIBA
Copy link
Contributor

@InzGIBA InzGIBA commented Oct 30, 2023

Changes:

  • Adding a check for the presence of created policies and a small code reduction (casbin_adapter/adapter.py)
  • DRY principle and correction E712 (casbin_adapter/enforcer.py)
  • fix typo in docstring and deletion of an unnecessary variable (casbin_adapter/utils.py)

@casbin-bot
Copy link

@Nekotoxin please review

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2023

CLA assistant check
All committers have signed the CLA.

@hsluoyz hsluoyz mentioned this pull request Oct 31, 2023
@hsluoyz
Copy link
Member

hsluoyz commented Oct 31, 2023

@InzGIBA plz fix CI errors:

image

@hsluoyz hsluoyz changed the title refactor: code refactoring feat: code refactoring and bug fixing Nov 3, 2023
@hsluoyz hsluoyz merged commit 81557ff into pycasbin:master Nov 3, 2023
24 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 3, 2023
# [1.2.0](v1.1.3...v1.2.0) (2023-11-03)

### Features

* code refactoring and bug fixing ([#29](#29)) ([81557ff](81557ff))
Copy link

github-actions bot commented Nov 3, 2023

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants