Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Hotfix for upstream dependency's incompatibility with Django 4.1 #31

Merged
merged 8 commits into from
Nov 5, 2022

Conversation

AetherUnbound
Copy link
Contributor

@AetherUnbound AetherUnbound commented Nov 5, 2022

Due to miracle2k/django-assets#102 (and the fact that we don't really have a way of migrating down when deploying), this is a hotfix that should still allow the manage.py assets build command to run.

To test locally, run just build then just manage assets build.

I've changed the post-compile script so that if any step fails, the whole build fails.

I've also added some CI/CD steps to check that assets can still be built.

@AetherUnbound AetherUnbound added bug Something isn't working dependencies Project dependencies labels Nov 5, 2022
@AetherUnbound AetherUnbound requested a review from a team November 5, 2022 21:01
@milktea02
Copy link
Contributor

I wonder if it'd be worth forking django-assets or finding an active fork since it hasn't had an update since 2020

I love testing with github actions!
@AetherUnbound
Copy link
Contributor Author

I wonder if it'd be worth forking django-assets or finding an active fork since it hasn't had an update since 2020

I know 😞 I've submitted miracle2k/django-assets#103 but I don't have high hopes it'll be merged/deployed any time soon. Def wanted to get a fix out first though as our site is presently broken 🤪

@AetherUnbound AetherUnbound merged commit 8c1733b into main Nov 5, 2022
@AetherUnbound AetherUnbound deleted the hotfix/django-4.1-assets-fix branch November 5, 2022 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working dependencies Project dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants