Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

Fixed directory creation on file download #220

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ftylitak
Copy link

@ftylitak ftylitak commented Oct 8, 2020

What does this implement/fix? Explain your changes.

While downloading the files contained in a Pycom device, the procedure generates errors due to inability to recursively create subfolders.

This error has already been fixed in the Pymakr for VS code by the commit pycom/pymakr-vsc@ee9b44e#diff-4526c02ea22c9a70285696db52fc53e6, so I applied the exact same code change.

Tested and working.

Does this close any currently open issues?

No.

Any relevant logs, error output, etc?

The stack trace is the following:

fs.js:122
Hide Stack Trace
Error: ENOENT: no such file or directory, mkdir '/home/user/project/lib/info'
    at Object.mkdirSync (fs.js:778:3)
    at Utils.ensureDirectoryExistence (/home/user/.atom/packages/pymakr/lib/helpers/utils.js:89:8)
    at Utils.ensureFileDirectoryExistence (/home/user/.atom/packages/pymakr/lib/helpers/utils.js:82:17)
    at /home/user/.atom/packages/pymakr/lib/features/sync/sync.js:426:21
    at /home/user/.atom/packages/pymakr/lib/board/shell.js:285:9 

Any other comments?

No.

Where has this been tested?

Operating system:
Ubuntu 20.04 kernel 5.4.0-48-generic

Atom version:
1.51.0 x64

Pymakr version:
2.1.5

vitorcalvi
vitorcalvi previously approved these changes Nov 21, 2020
@elmasria
Copy link
Contributor

Can you please merge with the latest Pymakr-atom (develop branch) and push changes to fix the tests?

@ftylitak ftylitak marked this pull request as draft April 27, 2021 15:49
@ftylitak ftylitak marked this pull request as ready for review April 27, 2021 15:55
@ftylitak
Copy link
Author

Sorry for the many month delay.

Hope now it is ready to be merged.

@jakobrosenberg
Copy link
Contributor

What's the status on this?

@elmasria
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants