Remove unreliable libmagic dependency and broken use of mimetypes #2365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Label error. Requires exactly 1 of: breaking, build, chore, ci, docs, feat, fix, perf, refactor, style, test. Found: dependencies. Follow https://www.conventionalcommits.org to get auto-labeling to work correctly. |
studioj
reviewed
Sep 13, 2025
The magic package for libmagic support has many different implementations that conflict with each other. For the avatar only JPEG, GIF and PNG are supported in Jira Could REST API and also BMP and WBMP for Data Center, so we can decide which it is ourselves.
kohtala
changed the title
|
I updated the description to be clearer on what are the problems in the current implementation and why this solution covers all the use cases we can support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The magic package for libmagic support has many different implementations that conflict with each other and I believe do not work on Windows.
The fallback attempt to use
mimetypeson atempfiledoes not work because on Linux the temporary file is created withO_TMPFILEand the filenameis integer for the file descriptor. On Windows it works no better because it relies on the file name extension and a temporary file does not have an extension set based on the content.For the avatar only JPEG, GIF and PNG are supported in Jira Could REST API and also BMP and WBMP for Data Center. Because we have only these types to recognize, it is easier for us to decide which it is ourselves than using a dependency.
This replaces solutions in #1847 #1867, #1891 and closes #1801 which should have been closed already.