Skip to content

fix: don’t forward empty JSON bodies on GET (prevents Jira 403) #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: don’t forward empty JSON bodies on GET (prevents Jira 403) #2388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions jira/resilientsession.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,14 @@ def _jira_prepare(self, **original_kwargs) -> dict:
prepared_kwargs["headers"] = request_headers

data = original_kwargs.get("data", None)
if isinstance(data, dict) and data:
# mypy ensures we don't do this,
# but for people subclassing we should preserve old behaviour
prepared_kwargs["data"] = json.dumps(data)
if isinstance(data, dict):
if data:
# mypy ensures we don't do this,
# but for people subclassing we should preserve old behaviour
prepared_kwargs["data"] = json.dumps(data)
else:
# Don't forward an empty JSON body
prepared_kwargs.pop("data", None)

if "verify" not in prepared_kwargs:
prepared_kwargs["verify"] = self.verify
Expand Down