Add Review Stages Setting

src/locale/en_US/LC_MESSAGES/django.po

@@ -1571,6 +1571,14 @@ msgstr "Change Password"
 msgid "Reviews"
 msgstr "Reviews"
 
+#: templates/default/_includes/dashboard_tablist.html:28
+#: templates/default/reviews/review_stages.html:16
+#: templates/default/reviews/review_stages.html:44
+#, fuzzy
+#| msgid "Reviews"
+msgid "Review Stages"
+msgstr "Reviews"
+
 #: templates/default/_includes/nav/dashboard_nav.html:10
 msgid "Log out"
 msgstr "Log out"
@@ -1799,6 +1807,7 @@ msgstr "Change Log In Password"
 
 #: templates/default/registration/password_change_form.html:22
 #: templates/default/reviews/review_form.html:101
+#: templates/default/reviews/review_stages.html:114
 msgid "Submit"
 msgstr "Submit"
 
@@ -2018,6 +2027,18 @@ msgstr "My Previous Reviews"
 msgid "Review Proposal"
 msgstr "Review Proposal"
 
+#: templates/default/reviews/review_stages.html:23
+#, fuzzy
+#| msgid "Current Review Stage: %(review_stage)s"
+msgid "Current Review Stage Setting"
+msgstr "Current Review Stage: %(review_stage)s"
+
+#: templates/default/reviews/review_stages.html:35
+#, fuzzy
+#| msgid "Personal Review Stats"
+msgid "Set Review Stage"
+msgstr "Personal Review Stats"
+
 #: templates/default/reviews/talk_proposal_list.html:14
 #, python-format
 msgid "Current Review Stage: %(review_stage)s"
@@ -5116,36 +5137,36 @@ msgstr "latest agreed CoC version"
 msgid "agreed at"
 msgstr "agreed at"
 
-#: users/views.py:44
+#: users/views.py:48
 msgid "Sign up successful. You are now logged in."
 msgstr "Sign up successful. You are now logged in."
 
-#: users/views.py:61
+#: users/views.py:65
 msgid "Email verification successful."
 msgstr "Email verification successful."
 
-#: users/views.py:73
+#: users/views.py:77
 #, python-brace-format
 msgid "A verification email has been sent to {email}"
 msgstr "A verification email has been sent to {email}"
 
-#: users/views.py:103
+#: users/views.py:107
 msgid "Your profile has been updated successfully."
 msgstr "Your profile has been updated successfully."
 
-#: users/views.py:116
+#: users/views.py:120
 msgid "Your new password has been applied successfully."
 msgstr "Your new password has been applied successfully."
 
-#: users/views.py:123
+#: users/views.py:127
 msgid ""
 "An email is sent to your email account. Please check your inbox for furthur "
 "instructions to reset your password."
 msgstr ""
 "An email is sent to your email account. Please check your inbox for furthur "
 "instructions to reset your password."
 
-#: users/views.py:131
+#: users/views.py:135
 msgid "Password reset successful. You can now login."
 msgstr "Password reset successful. You can now login."
 

src/locale/zh_Hant/LC_MESSAGES/django.po

@@ -1524,6 +1524,12 @@ msgstr "更改密碼"
 msgid "Reviews"
 msgstr "審查"
 
+#: templates/default/_includes/dashboard_tablist.html:28
+#: templates/default/reviews/review_stages.html:16
+#: templates/default/reviews/review_stages.html:44
+msgid "Review Stages"
+msgstr "審查階段"
+
 #: templates/default/_includes/nav/dashboard_nav.html:10
 msgid "Log out"
 msgstr "登出"
@@ -1747,6 +1753,7 @@ msgstr "更改密碼"
 
 #: templates/default/registration/password_change_form.html:22
 #: templates/default/reviews/review_form.html:101
+#: templates/default/reviews/review_stages.html:114
 msgid "Submit"
 msgstr "送出"
 
@@ -1960,6 +1967,14 @@ msgstr "我之前的審查意見"
 msgid "Review Proposal"
 msgstr "審查提案"
 
+#: templates/default/reviews/review_stages.html:23
+msgid "Current Review Stage Setting"
+msgstr "目前審查階段設定"
+
+#: templates/default/reviews/review_stages.html:35
+msgid "Set Review Stage"
+msgstr "設定審查階段"
+
 #: templates/default/reviews/talk_proposal_list.html:14
 #, python-format
 msgid "Current Review Stage: %(review_stage)s"
@@ -4991,35 +5006,35 @@ msgstr "最後同意的 CoC 版本"
 msgid "agreed at"
 msgstr "同意於"
 
-#: users/views.py:44
+#: users/views.py:48
 msgid "Sign up successful. You are now logged in."
 msgstr "註冊成功。您現在已被登入。"
 
-#: users/views.py:61
+#: users/views.py:65
 msgid "Email verification successful."
 msgstr "Email 認證成功。"
 
-#: users/views.py:73
+#: users/views.py:77
 #, python-brace-format
 msgid "A verification email has been sent to {email}"
 msgstr "一封認證用的 email 已經寄送至 {email}"
 
-#: users/views.py:103
+#: users/views.py:107
 msgid "Your profile has been updated successfully."
 msgstr "您的講者資訊已成功地更新。"
 
-#: users/views.py:116
+#: users/views.py:120
 msgid "Your new password has been applied successfully."
 msgstr "已成功地使用您的新密碼。"
 
-#: users/views.py:123
+#: users/views.py:127
 msgid ""
 "An email is sent to your email account. Please check your inbox for furthur "
 "instructions to reset your password."
 msgstr ""
 "一封電子郵件已經發送至您的信箱。請檢查您的收件匣並參照信中指示重設密碼。"
 
-#: users/views.py:131
+#: users/views.py:135
 msgid "Password reset successful. You can now login."
 msgstr "密碼重設成功。您現在即可登入。"
 

src/proposals/templatetags/proposals.py

@@ -1,3 +1,4 @@
+from django.conf import settings
 from django.template import Library
 
 from proposals.utils import SEP_DEFAULT, SEP_LAST, format_names
@@ -7,6 +8,11 @@
 
 @register.filter
 def speaker_names_display(
-        proposal, sep_default=SEP_DEFAULT, sep_last=SEP_LAST):
+    proposal, sep_default=SEP_DEFAULT, sep_last=SEP_LAST):
     names = [info.user.speaker_name for info in proposal.speakers]
     return format_names(names, sep_default=sep_default, sep_last=sep_last)
+
+
+@register.filter
+def configuration_switch(value):
+    return settings.CONFERENCE_DEFAULT_SLUG + value

src/proposals/tests/test_templatetags.py

@@ -53,3 +53,34 @@ def test_speaker_names_display(talk_proposals, parser):
         </ul>
     """)
     assert actual == expected
+
+@pytest.fixture
+def review_stage_keys():
+    review_stage_keys = [
+        '.proposals.creatable', '.proposals.editable', '.proposals.withdrawable',
+        '.reviews.visible.to.submitters', '.reviews.stage',
+        '.proposals.disable.after'
+    ]
+    return review_stage_keys
+
+def test_configuration_switch(review_stage_keys, parser):
+    result = render_template(
+        '{% load proposals %}'
+        '<ul>'
+        '{% for review_stage_key in proposals %}'
+        '<li>{{ review_stage_key|configuration_switch }}</li>'
+        '{% endfor %}'
+        '</ul>', {'proposals': review_stage_keys},
+    )
+    actual = parser.arrange(parser.parse(text=result, create_parent=False))
+    expected = parser.arrange("""
+        <ul>
+          <li>pycontw-2021.proposals.creatable</li>
+          <li>pycontw-2021.proposals.editable</li>
+          <li>pycontw-2021.proposals.withdrawable</li>
+          <li>pycontw-2021.reviews.visible.to.submitters</li>
+          <li>pycontw-2021.reviews.stage</li>
+          <li>pycontw-2021.proposals.disable.after</li>
+        </ul>
+    """)
+    assert actual == expected

src/reviews/tests/test_views.py

@@ -0,0 +1,82 @@
+from unittest.mock import patch
+
+import pytest
+from django.urls import reverse
+
+
+@pytest.fixture
+def review_stages_url():
+    return reverse('review_stages')
+
+@pytest.mark.django_db
+def test_review_stages_get(client, review_stages_url):
+    response = client.get(review_stages_url)
+
+    assert response.status_code == 200
+    assert 'review_stages_list' in response.context
+    assert 'current_review_stages_setting' in response.context
+
+@pytest.mark.django_db
+@patch('reviews.views.reg')
+@patch('reviews.views.messages')
+def test_review_stages_post_valid_data(mock_messages, mock_reg, client, review_stages_url):
+    mock_reg.get.return_value = ''
+    mock_reg.__setitem__.side_effect = lambda key, value: None
+
+    post_data = {
+        'proposals.creatable': 'True',
+        'proposals.editable': 'True',
+        'proposals.withdrawable': 'True',
+        'reviews.visible.to.submitters': 'True',
+        'reviews.stage': '1',
+        'proposals.disable.after': '2024-12-31T12:00',
+        'review_timezone': 'UTC',
+    }
+
+    response = client.post(review_stages_url, post_data)
+
+    assert response.status_code == 200
+    mock_messages.info.assert_called_once_with(
+        response.wsgi_request, 'This setting has been changed successfully.'
+    )
+
+@pytest.mark.django_db
+@patch('reviews.views.reg')
+@patch('reviews.views.messages')
+def test_review_stages_post_invalid_date(mock_messages, mock_reg, client, review_stages_url):
+    post_data = {
+        'proposals.creatable': 'True',
+        'proposals.editable': 'True',
+        'proposals.withdrawable': 'True',
+        'reviews.visible.to.submitters': 'True',
+        'reviews.stage': '1',
+        'proposals.disable.after': 'invalid-date',
+        'review_timezone': '',
+    }
+
+    response = client.post(review_stages_url, post_data)
+
+    assert response.status_code == 200
+    mock_messages.error.assert_called_once_with(
+        response.wsgi_request, 'Please input valid date format : " + "%Y-%m-%dT%H:%M'
+    )
+
+@pytest.mark.django_db
+def test_review_stages_timezone_conversion(client, review_stages_url):
+    post_data = {
+        'proposals.creatable': 'True',
+        'proposals.editable': 'True',
+        'proposals.withdrawable': 'True',
+        'reviews.visible.to.submitters': 'True',
+        'reviews.stage': '1',
+        'proposals.disable.after': '2024-12-31T12:00',
+        'review_timezone': 'Asia/Taipei',
+    }
+
+    with patch('reviews.views.pytz.timezone') as mock_timezone:
+        mock_timezone.return_value.localize.return_value.strftime.return_value = '2024-12-31 12:00:00-0500'
+        response = client.post(review_stages_url, post_data)
+
+    assert response.status_code == 200
+    assert mock_timezone.call_count == 1
+    assert mock_timezone.called_with('Asia/Taipei')

src/reviews/urls.py

@@ -1,9 +1,11 @@
 from django.conf.urls import url
 
+from . import views
 from .views import ReviewEditView, TalkProposalListView
 
 urlpatterns = [
     url(r'^$', TalkProposalListView.as_view(), name='review_proposal_list'),
     url(r'^talk/(?P<proposal_pk>\d+)/$',
         ReviewEditView.as_view(), name='review_edit'),
+    url(r'^review-stages/$', views.review_stages, name='review_stages'),
 ]