Skip to content

Commit

Permalink
fix NavBarHamburger and NavBar
Browse files Browse the repository at this point in the history
get showProposalSystemPage from store.configs and sync the name convention.
  • Loading branch information
SivanYeh committed Feb 1, 2024
1 parent 99bdf70 commit 0a5348b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
5 changes: 4 additions & 1 deletion components/core/header/nav-bar/NavBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
>
</nav-bar-item-dropdown>
<ext-link
v-if="showProposalSystem"
v-if="showProposalSystemPage"
:href="proposalSystemUrl"
:class="getPageClassesByPath('proposalSystemUrl', true)"
>
Expand Down Expand Up @@ -148,6 +148,9 @@ export default {
showVenuePage() {
return this.$store.state.configs.showVenuePage
},
showProposalSystemPage() {
return this.$store.state.configs.showProposalSystemPage
},
},
methods: {
generateI18nItems(items, hideItems = []) {
Expand Down
5 changes: 4 additions & 1 deletion components/core/header/nav-bar/NavBarHamburger.vue
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
@click.native="toggleAccordion('venue')"
></nav-bar-item-accordion>
<ext-link
v-if="showProposalSystem"
v-if="showProposalSystemPage"
class="core-navBarHamburgerSlideInMenu__item"
:href="proposalSystemUrl"
>{{ $t('proposalSystemUrl') }}</ext-link
Expand Down Expand Up @@ -174,6 +174,9 @@ export default {
showVenuePage() {
return this.$store.state.configs.showVenuePage
},
showProposalSystemPage() {
return this.$store.state.configs.showProposalSystemPage
},
},
watch: {
$route() {
Expand Down
2 changes: 1 addition & 1 deletion store/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const state = () => ({
showEventsPage: false,
showConferencePage: false,
showVenuePage: false,
showProposalSystem: false,
showProposalSystemPage: true,
showIndexSponsorSection: false,
showIndexSecondaryBtn: true,
aboutHideItems: ['apacCommunity'], // ['pycontw', 'apacCommunity', 'history', 'community', 'codeOfConduct']
Expand Down

0 comments on commit 0a5348b

Please sign in to comment.