Changes for generating full static site #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josix
force-pushed
the
feat/generate-static-site
branch
2 times, most recently
from
503ff81 to
664e595
Compare
|
CI failed due to no dependency of axios. (we use |
josix
force-pushed
the
feat/generate-static-site
branch
2 times, most recently
from
db2806e to
3fc4a62
Compare
…use asyncData fetching data
Closed
fix(header/style): update color of menu and icon to pink-700
…to feat/generate-static-site
yungshenglu
reviewed
Jan 18, 2023
| eventType: params.eventType, | ||
| eventId: params.id, | ||
| }) | ||
| const speechData = store.state.speechData |
There was a problem hiding this comment.
store.state?.speechData
yungshenglu
reviewed
Jan 18, 2023
Comment on lines
+192
to
+193
| eventType: params.eventType, | ||
| eventId: params.id, |
There was a problem hiding this comment.
eventType: params?.eventType,
eventId: params?.id,
yungshenglu
reviewed
Jan 18, 2023
| await store.dispatch('$getSpeechesData', eventType) | ||
| const speechesData = store.state.speechesData.map((speech) => ({ | ||
| ...speech, | ||
| begin_time: speech.begin_time ? new Date(speech.begin_time) : null, |
yungshenglu
reviewed
Jan 18, 2023
| async asyncData({ store, app }) { | ||
| await store.dispatch('$getKeynotesData') | ||
|
|
||
| const keynotesData = store.state.keynotesData.map((keynote) => ({ |
There was a problem hiding this comment.
const keynotesData = store.state?.keynotesData.map((keynote) => ({
yungshenglu
reviewed
Jan 18, 2023
| @@ -120,6 +119,13 @@ export default { | |||
| I18nPageWrapper, | |||
| Intro, | |||
| }, | |||
| async asyncData({ store }) { | |||
| await store.dispatch('$getSponsorsData') | |||
| const sponsorsData = store.state.sponsorsData | |||
There was a problem hiding this comment.
const sponsorsData = store.state?.sponsorsData
yungshenglu
reviewed
Jan 18, 2023
| @@ -39,19 +39,24 @@ export default { | |||
| JobsCardCollection, | |||
| JobsPanel, | |||
| }, | |||
| async asyncData({ store, app }) { | |||
| await store.dispatch('$getJobsData') | |||
| const jobsData = store.state.jobsData.map((sponsor) => ({ | |||
There was a problem hiding this comment.
const jobsData = store.state?.jobsData.map((sponsor) => ({
yungshenglu
reviewed
Jan 18, 2023
| const eventType = params.eventType | ||
| if (!['talks', 'tutorials'].includes(eventType)) { | ||
| redirect('/') | ||
| } | ||
| await store.dispatch('$getSpeechesData', eventType) | ||
| const speechesData = store.state.speechesData.map((speech) => ({ |
There was a problem hiding this comment.
const speechesData = store.state?.speechesData.map((speech) => ({
yungshenglu
reviewed
Jan 18, 2023
| `${DEFAULT_BASE_URL}/api/events/speeches/${tutorial.event_type}/${tutorial.id}/`, | ||
| config, | ||
| ) | ||
| .then((response) => response.data) |
There was a problem hiding this comment.
.then((response) => response?.data)
|
Duplicated with #380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Steps to Test This Pull Request
npm run json-servernpm run generatenpm run startExpected behavior
Related Issue
(Not sure if it could fix_ #308)
Fix #339