Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(homepage): adjust the join_us button setting #478

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix(homepage): adjust the join_us button setting #478

merged 1 commit into from
Feb 13, 2024

Conversation

hsuanchi
Copy link
Member

Types of changes

  • Bugfix

Description

fix #467 issue

Steps to Test This Pull Request

  1. Navigate to 'https://tw.pycon.org/2024/zh-hant'.
  2. Observe the "Join Us" and "Call for Proposals" buttons in the middle section of the homepage.

Expected behavior

  1. The button size should be consistent.

Related Issue

Additional context

@netlify Netlify
Copy link

netlify bot commented Feb 12, 2024

👷 Deploy request for ephemeral-sable-89c7e0 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e5f8cdd

@hsuanchi hsuanchi requested a review from SivanYeh February 13, 2024 05:51
@SivanYeh
Copy link
Collaborator

LGTM! Works good here
image

@SivanYeh SivanYeh merged commit 8d3751c into pycontw:main Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanYeh SivanYeh SivanYeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] Home Page Button Size Inconsistency
2 participants
@hsuanchi @SivanYeh