fixup! fix: prevent generation failed due to 4xx, 5xx api error #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ephemeral-sable-89c7e0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
baby230211
reviewed
Apr 12, 2024
There was a problem hiding this comment.
Due to we guarantee that talks and tutorials can be empty array if error on api.
Maybe we can remove this condition in
pycontw-frontend/nuxt.config.js
Lines 32 to 34 in dd3bc6f
josix
force-pushed
the
fix/ssg-failed-due-to-api-error
branch
from
dd3bc6f to
a6e9ae6
Compare
|
Revised, thanks for pointing it ou. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement according to #507
Types of changes
Description
update to prevent all failures when getting talks/tutorials
Steps to Test This Pull Request
Expected behavior
Related Issue
#507
Additional context