Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] change privacy-policy class style to tailwind inlines #512

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[feat] change privacy-policy class style to tailwind inlines #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 11 additions & 38 deletions pages/about/privacy-policy.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div>
<banner>
<core-h1 :title="`${conferenceYear} ${$t('title')}`"></core-h1>
<i18n path="pageAbstract" tag="p" class="pageAbstract">
<i18n path="pageAbstract" tag="p" class="text-xs md:text-base">
<template #br><br /></template>
</i18n>
</banner>
Expand All @@ -15,10 +15,10 @@
<i18n
:path="contents.title"
tag="h2"
class="paragraphTitle"
class="mt-9 text-center font-serif text-base font-bold text-pink-700 md:mt-20 md:text-left md:text-xl"
></i18n>
<i18n
v-for="(content, j) in contents.description"
v-for="(_, j) in contents.description"
:key="`privacy_policy_description_${j}`"
:path="`contents.${i}.description.${j}`"
class="paragraphDescription"
Expand All @@ -31,44 +31,44 @@

<ol class="list-decimal pl-8">
<i18n
v-for="(content, j) in contents.items"
v-for="(_, j) in contents.items"
:key="`privacy_policy_items_${j}`"
:path="`contents.${i}.items.${j}`"
class="paragraphDescription"
tag="li"
></i18n>
</ol>
<i18n
v-for="(content, j) in contents.summary"
v-for="(_, j) in contents.summary"
:key="`privacy_policy_summary_${j}`"
:path="`contents.${i}.summary.${j}`"
class="paragraphDescription"
tag="p"
/>
</div>
<div class="pt-8">
<i18n path="question" tag="p" class="question">
<i18n path="question" tag="p" class="text-center text-xs">
<template #contact>
<ext-link href="mailto:[email protected]" highlight
>{{ $t(`terms.contact`) }}
</ext-link>
</template>
</i18n>
</div>
<div class="authorization pb-5">
<div class="pb-5 text-center">
<div>
<i18n
path="authorization.title"
tag="h2"
class="authorizationTitle"
class="mt-9 text-center font-serif text-base font-bold text-pink-700 md:mt-20 md:text-xl"
>
</i18n>
</div>
<div>
<i18n
path="authorization.description"
tag="p"
class="authorizationDescription"
class="text-center text-xs md:text-sm"
>
<template #br><br /></template>
<template #license>
Expand All @@ -81,12 +81,12 @@
</i18n>
</div>
<div>
<img :src="authorizationIcon" class="authorizationLabel" />
<img :src="authorizationIcon" class="m-auto w-64 md:w-80" />
</div>
<i18n
path="authorization.content"
tag="p"
class="authorizationContent"
class="text-center text-xs md:text-sm"
>
<template #br><br /></template>
</i18n>
Expand Down Expand Up @@ -147,34 +147,7 @@ export default {
</script>

<style lang="postcss" scoped>
.paragraphTitle {
@apply mt-9 text-center font-serif text-base font-bold text-pink-700 md:mt-20 md:text-left md:text-xl;
}

.paragraphDescription {
@apply text-xs md:text-sm;
}

.pageAbstract {
@apply text-xs md:text-base;
}
.authorization {
@apply text-center;
}
.authorizationTitle {
@apply mt-9 text-center font-serif text-base font-bold text-pink-700 md:mt-20 md:text-left md:text-xl;
@apply text-center;
}
.authorizationDescription {
@apply text-center text-xs md:text-sm;
}
.authorizationLabel {
@apply m-auto w-64 md:w-80;
}
.authorizationContent {
@apply text-center text-xs md:text-sm;
}
.question {
@apply text-center text-xs;
}
</style>
1 change: 1 addition & 0 deletions tailwind.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ module.exports = {
mode: 'jit',
purge: [],
darkMode: false, // or 'media' or 'class'
important: true,
Copy link
Collaborator

@baby230211 baby230211 Apr 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to this config may affected all site of css, we cannot guarantee that all page is correct.

I don't think it's a good idea to add important in every tailwind generated css.

If we're going to migrate scss to tailwind, then maybe we should have a migration plan or review the new code and refactor to tailwind in every new PRs of new code.

theme: {
fontFamily: {
sans: [
Expand Down
Loading