feat: add a new tab #515
Merged
feat: add a new tab #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But, I don't update the data of web.
✅ Deploy Preview for ephemeral-sable-89c7e0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SivanYeh
reviewed
Apr 22, 2024
| @@ -11,6 +11,7 @@ export default Object.freeze({ | |||
| { i18nKey: 'talk', value: '/speaking/talk' }, | |||
| { i18nKey: 'tutorial', value: '/speaking/tutorial' }, | |||
| { i18nKey: 'recording', value: '/speaking/recording' }, | |||
| { i18nKey: 'post session', value: '/speaking/post-session' }, | |||
There was a problem hiding this comment.
"poster session" might be more accurate. Remember to add the item at /components/core/header/nav-bar/NavBar.i18n.js too
SivanYeh
reviewed
Apr 22, 2024
pages/speaking/post-session.vue
Outdated
| } | ||
| }, | ||
| computed: { | ||
| previousConfLinks() { |
There was a problem hiding this comment.
You can delete previousConfLinks here.
SivanYeh
reviewed
Apr 22, 2024
pages/speaking/post-session.vue
Outdated
| }, | ||
| { | ||
| tag: 'howToSubmit', | ||
| isDescriptionList: false, |
There was a problem hiding this comment.
set it to "true" will be better.
|
@Ritabear Well done! You've done a great job 👍 |
Update content in topics and howToSubmit.
Remove redundancy codes such as Steps, and unrelated links.
SivanYeh
force-pushed
the
feat/add_a_tab
branch
from
41bd9cb to
86e0ff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to add a new tab on the official website.
The tab's name is "poster-session".
Description
Now, I add a tab on the website, but I don't update the data on web. (wait for the content)
Expected behavior
We can watch the new tab, which includes new content.
Related Issue
#506