Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keynote): toggle keynote and fix js error in server #536

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

baby230211
Copy link
Collaborator

@baby230211 baby230211 commented Jun 4, 2024

Types of changes

Fix #526

  • New feature
  1. Toggle On keynote page.
  2. Fix the javascript replaceAll error, because of old node js version.

Description

  1. Go to path 2024/zh-hant/conference/keynotes

Expected behavior

Related Issue

Additional context

keynote Screenshot:
截圖 2024-06-04 下午9 07 29

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for classy-granita-bc2b5a ready!

Name Link
🔨 Latest commit ce9faad
🔍 Latest deploy log https://app.netlify.com/sites/classy-granita-bc2b5a/deploys/665f1181c8cf0c00087cd8a4
😎 Deploy Preview https://deploy-preview-536--classy-granita-bc2b5a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@baby230211 baby230211 requested review from SivanYeh and josix June 4, 2024 13:09
Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
🔨 Latest commit ce9faad
🔍 Latest deploy log https://app.netlify.com/sites/zesty-gnome-f04144/deploys/665f11817b816c0007c3dc48
😎 Deploy Preview https://deploy-preview-536--zesty-gnome-f04144.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SivanYeh
Copy link
Collaborator

SivanYeh commented Jun 5, 2024

Preview is working weird. I will deploy on my local later and check

@baby230211
Copy link
Collaborator Author

The preview links work fine to me.

@SivanYeh
Copy link
Collaborator

SivanYeh commented Jun 5, 2024

@baby230211 This is mine lol:
image

Copy link
Collaborator

@SivanYeh SivanYeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baby230211
Copy link
Collaborator Author

@baby230211 baby230211 merged commit e678c98 into main Jun 8, 2024
9 checks passed
@baby230211 baby230211 deleted the feat/keynote-2024 branch June 8, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[program] - 官網 - Keynote 資訊
2 participants