Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(speech): toggle talks and tutorials pages #550

Merged
merged 5 commits into from
Jul 14, 2024

Conversation

SivanYeh
Copy link
Collaborator

@SivanYeh SivanYeh commented Jul 2, 2024

Types of changes

  • New feature

Description

Switch on 2024 Tutorials(專業課程) and Talks(一般演講) pages

Steps to Test This Pull Request

  1. Go to path/2024/zh-hant/conference/talks
  2. Go to path/2024/zh-hant/conference/tutorials
  3. Check if they can be entered from navigation bar "Conference/Talks" and "Conference/Tutorials"

Expected behavior

image

Related Issue

#529
#528

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for classy-granita-bc2b5a ready!

Name Link
🔨 Latest commit e5b04a8
🔍 Latest deploy log https://app.netlify.com/sites/classy-granita-bc2b5a/deploys/66933a9c8911620008f5ab60
😎 Deploy Preview https://deploy-preview-550--classy-granita-bc2b5a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
🔨 Latest commit e5b04a8
🔍 Latest deploy log https://app.netlify.com/sites/zesty-gnome-f04144/deploys/66933a9c45add0000959682a
😎 Deploy Preview https://deploy-preview-550--zesty-gnome-f04144.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SivanYeh
Copy link
Collaborator Author

SivanYeh commented Jul 2, 2024

@mattwang44 @josix 本地端點擊任一演講區塊出現錯誤。我漏開了什麼嗎?
點擊:
image

出現錯誤:
image

GET /speeches/?event_type=talk,sponsored 304 9.700 ms - -
GET /speeches/?event_type=talk&id=3&singular=1 304 4.415 ms - -
GET /speeches/?event_type=category&id=SEC&singular=1 404 3.363 ms - 2

@mattwang44
Copy link
Member

有跑 npm run json-server 嗎?
這個頁面上的資料是透過 API 拿到的(local dev 現在應該還是?)

@SivanYeh
Copy link
Collaborator Author

SivanYeh commented Jul 2, 2024

有跑npm run json-server~
local dev有輸入兩筆假資料. 不過按照顯示結果應該是直接去API抓

@SivanYeh SivanYeh marked this pull request as ready for review July 3, 2024 10:13
@mattwang44
Copy link
Member

mattwang44 commented Jul 4, 2024

@SivanYeh please test it out with this patch #551

SivanYeh added 2 commits July 11, 2024 21:53
fix(dev): json-server does not return correct speech data
fix(speech): intro in Talks

fix(speech): intro in Talks
@SivanYeh
Copy link
Collaborator Author

@tomatoprinx The previous is fixed by Matt. Please check again on your local~

@SivanYeh SivanYeh merged commit fa2a2e1 into main Jul 14, 2024
9 checks passed
@SivanYeh SivanYeh deleted the feat/2024-tutorial-talk branch July 14, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants