Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(about/coc): Convert PNG to SVG and Adjust CSS #563

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

foxlee2525
Copy link
Contributor

Types of changes

  • Bugfix
  • Refactoring

Description

  1. 新增了 COC 頁面 Icon 所對應的 SVG 檔案。
  2. 將舊有的 Icon PNG 替換成 SVG,同時試著修改了一些 CSS,讓它們更符合 Define Style coding convention #396 的規範。
  3. 修正了 two-column layout 的 grid 在 1024px - 1194px 時會失效的問題。

Steps to Test This Pull Request

  1. 到 "http://localhost:3000/2024/en-us/about/code-of-conduct"
  2. 放大網頁至 200%,瀏覽 Icon 會否變形,或非 SVG 檔案
  3. 縮放網頁,檢查在 width: 1194px 斷點時,grid 會不會正常更動

Expected behavior

Related Issue

#558

Screenshot

image

Add SVG files for COC Icon.
Replace PNG images with SVG, update CSS.
Fixed the issue where the grid layout did not activate at the intended screen size.
Copy link

netlify bot commented Aug 7, 2024

👷 Deploy request for classy-granita-bc2b5a pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 45b1117

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
🔨 Latest commit 45b1117
🔍 Latest deploy log https://app.netlify.com/sites/zesty-gnome-f04144/deploys/66b333191668af0008a14ae5
😎 Deploy Preview https://deploy-preview-563--zesty-gnome-f04144.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@foxlee2525 foxlee2525 requested a review from SivanYeh August 7, 2024 18:58
Copy link
Collaborator

@SivanYeh SivanYeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Here are my suggestions(just being picky, honestly you’ve done a great job :D ):

  1. You can move the content related to png/svg icon transformation from the second commit 086d8dc into the first commit 12ff581, so future developers can tell whether it’s the adjustment for inline style or svg icons. (Hint: using git rebase and git reset to organize the commit history)

  2. You can add the purpose of the css update in the 086d8dc commit message such as “Replace PNG images with SVG, update CSS to match the inline style suggested in PR#396.

@SivanYeh SivanYeh merged commit 4e8bbe9 into pycontw:main Aug 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants