Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSid output format #136

Merged
merged 5 commits into from
Aug 30, 2024
Merged

NSid output format #136

merged 5 commits into from
Aug 30, 2024

Conversation

Slautin
Copy link
Collaborator

@Slautin Slautin commented Aug 23, 2024

The output type of the Nsid Reader has changed from list() to dict().

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.54%. Comparing base (b0e7526) to head (a826b2f).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
SciFiReaders/readers/SID/Nsid_reader.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   60.55%   60.54%   -0.01%     
==========================================
  Files          52       52              
  Lines        4259     4263       +4     
==========================================
+ Hits         2579     2581       +2     
- Misses       1680     1682       +2     
Flag Coverage Δ
unittests 60.54% <82.35%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramav87 ramav87 merged commit a00cbdc into main Aug 30, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants