Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batson, try 2 #188

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

batson, try 2 #188

wants to merge 14 commits into from

Conversation

davidhewitt
Copy link
Collaborator

Followup from #136, rebased on main.

I will review and proceed further now...

Copy link

codspeed-hq bot commented Feb 13, 2025

CodSpeed Performance Report

Merging #188 will not alter performance

Comparing dh/batson (23781b0) with main (4023ba1)

Summary

✅ 70 untouched benchmarks

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 82.40850% with 298 lines in your changes missing coverage. Please review.

Project coverage is 86.23%. Comparing base (4023ba1) to head (23781b0).

Files with missing lines Patch % Lines
crates/batson/src/decoder.rs 61.53% 20 Missing and 45 partials ⚠️
crates/batson/src/object.rs 88.07% 27 Missing and 25 partials ⚠️
crates/batson/src/array.rs 87.43% 12 Missing and 36 partials ⚠️
crates/batson/src/header.rs 78.04% 32 Missing and 13 partials ⚠️
crates/batson/src/errors.rs 0.00% 34 Missing ⚠️
crates/batson/src/get.rs 84.61% 16 Missing and 14 partials ⚠️
crates/batson/src/encoder.rs 91.13% 5 Missing and 9 partials ⚠️
crates/batson/src/lib.rs 85.00% 3 Missing and 3 partials ⚠️
crates/batson/src/json_writer.rs 94.66% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   88.36%   86.23%   -2.13%     
==========================================
  Files          12       21       +9     
  Lines        2106     3800    +1694     
  Branches     2106     3800    +1694     
==========================================
+ Hits         1861     3277    +1416     
- Misses        151      282     +131     
- Partials       94      241     +147     
Files with missing lines Coverage Δ
crates/batson/src/json_writer.rs 94.66% <94.66%> (ø)
crates/batson/src/lib.rs 85.00% <85.00%> (ø)
crates/batson/src/encoder.rs 91.13% <91.13%> (ø)
crates/batson/src/get.rs 84.61% <84.61%> (ø)
crates/batson/src/errors.rs 0.00% <0.00%> (ø)
crates/batson/src/header.rs 78.04% <78.04%> (ø)
crates/batson/src/array.rs 87.43% <87.43%> (ø)
crates/batson/src/object.rs 88.07% <88.07%> (ø)
crates/batson/src/decoder.rs 61.53% <61.53%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4023ba1...23781b0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants