Add 6 instrument methods #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
b9e3f68
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://96cdba73.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-instrument-6.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
Need to remember to add |
Kludex
approved these changes
Jun 3, 2024
| from starlette.applications import Starlette | ||
|
|
||
|
|
||
| def instrument_starlette(app: Starlette, **kwargs: Any): |
There was a problem hiding this comment.
As a user, I would have to go to the OTel documentation to see which ones are the kwargs. I think we should correctly type hint instead of using the kwargs.
If the argument for doing it like this is because they may break our API, we can just do the if TYPE_CHECKING trick. It just provides a far better experience.
There was a problem hiding this comment.
Yes, we should do that eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #193