Document deprecated process runtime metrics #930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion in https://pydantic.slack.com/archives/C0813FX362E/p1741867835353059
In open-telemetry/opentelemetry-python-contrib#3250, these:
were deprecated in favour of:
The new metrics are already being emitted alongside the old ones when using
logfire.instrument_system_metrics(base='full')
, we just note this in the docs and update the tests.The default
logfire.instrument_system_metrics()
hasn't changed and isn't yet.Both should be updated next time we make a major release: #932
Also added a new metric
process.cpu.core_utilization
which is equivalent toprocess.runtime.cpu.utilization
in value.process.cpu.utilization
isn't equivalent because it's divided by the number of cores which makes it less useful IMO.Update to dashboard template: https://github.com/pydantic/platform/pull/8435