Skip to content

add identifier field to BinaryContent class #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 18, 2025
Merged

add identifier field to BinaryContent class #2231

merged 4 commits into from
Jul 18, 2025

Conversation

GDaamn
Copy link
Contributor

@GDaamn GDaamn commented Jul 17, 2025

Closes #2139

  • Adds an optional identifier field to the BinaryContent class that can be set by the user to identify the content
  • Supporting unit tests to check if the agent returns the correct identifier that was passed as input

DouweM
DouweM requested changes Jul 17, 2025
View reviewed changes
@DouweM DouweM self-assigned this Jul 17, 2025
@GDaamn GDaamn requested a review from DouweM July 17, 2025 18:52
@DouweM DouweM merged commit babc23b into pydantic:main Jul 18, 2025
18 checks passed
@DouweM
Copy link
Contributor

DouweM commented Jul 18, 2025

@GDaamn Thank you!

@DouweM DouweM mentioned this pull request Jul 18, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DouweM DouweM Awaiting requested review from DouweM

Assignees

@DouweM DouweM

Labels
awaiting author revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add optional src or metadata field to BinaryContent
2 participants
@GDaamn @DouweM