Skip to content

Remove core schema validation #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove core schema validation #1715

wants to merge 3 commits into from

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented May 19, 2025

The code used to generate the self schema is inspecting annotations in a way that isn't compatible with Python 3.14.

Change Summary

The code used to generate the self schema is inspecting annotations
in a way that isn't compatible with Python 3.14.

Fixes #1601.

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

The code used to generate the self schema is inspecting annotations
in a way that isn't compatible with Python 3.14.
@Viicos Viicos force-pushed the remove-schema-validation branch from 4259faf to 79cbb1a Compare May 19, 2025 11:09
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this cleanup, awesome 👍

@Viicos Viicos mentioned this pull request May 25, 2025
4 tasks
@Viicos Viicos force-pushed the remove-schema-validation branch 2 times, most recently from 6d18fab to f87a5c8 Compare May 25, 2025 12:23
Copy link

codspeed-hq bot commented May 25, 2025

CodSpeed Performance Report

Merging #1715 will improve performances by ×2.1

Comparing remove-schema-validation (c9b2f19) with main (22d34a7)

Summary

⚡ 1 improvements
✅ 156 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_schema 732.9 µs 344.6 µs ×2.1

@Viicos Viicos force-pushed the remove-schema-validation branch from f87a5c8 to 95baa0b Compare May 25, 2025 12:44
@Viicos Viicos force-pushed the remove-schema-validation branch from 95baa0b to 1b67cd3 Compare May 25, 2025 13:17
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove validate_core_schema logic around ~pydantic v2.13
2 participants