Skip to content

Conversation

@friendlymatthew
Copy link
Member

Change Summary

This PR deduplicates keys in JsonValue::as_kwargs before populating a PyDict to avoid creating Python objects for values that will be overwritten by duplicate keys

@friendlymatthew friendlymatthew force-pushed the friendlymatthew/dedup-keys-before-building-dict branch from ab73a5e to 653f723 Compare October 27, 2025 23:09
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 27, 2025

CodSpeed Performance Report

Merging #1865 will degrade performances by 11.39%

Comparing friendlymatthew/dedup-keys-before-building-dict (2bbac0c) with main (f892755)

Summary

❌ 1 regression
✅ 162 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_set_of_ints_core_json_duplicates 382.7 µs 431.9 µs -11.39%

@friendlymatthew friendlymatthew force-pushed the friendlymatthew/dedup-keys-before-building-dict branch 2 times, most recently from 7b9f72b to 91d2202 Compare October 27, 2025 23:26
@friendlymatthew friendlymatthew force-pushed the friendlymatthew/dedup-keys-before-building-dict branch from 91d2202 to 2bbac0c Compare October 27, 2025 23:27
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

@davidhewitt davidhewitt merged commit 9672f39 into main Oct 29, 2025
32 of 33 checks passed
@davidhewitt davidhewitt deleted the friendlymatthew/dedup-keys-before-building-dict branch October 29, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants