Skip to content

Commit

Permalink
📝 Fix Issue of Currency in docstring (#235)
Browse files Browse the repository at this point in the history
* isolate url

My shell added the dot to the url and brought me to a non existing wikipedia page. Adding a space after the url prevents that from happening

* fix test
  • Loading branch information
edasubert authored Nov 10, 2024
1 parent f843f37 commit f27a132
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pydantic_extra_types/currency_code.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def _validate(cls, currency_symbol: str, _: core_schema.ValidationInfo) -> str:
raise PydanticCustomError(
'InvalidCurrency',
'Invalid currency code.'
' See https://en.wikipedia.org/wiki/ISO_4217. '
' See https://en.wikipedia.org/wiki/ISO_4217 . '
'Bonds, testing and precious metals codes are not allowed.',
)
return currency_symbol
Expand Down
2 changes: 1 addition & 1 deletion tests/test_currency_code.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def test_forbidden_everyday(forbidden_currency):
ValidationError,
match=re.escape(
'1 validation error for CurrencyCheckingModel\ncurrency\n '
'Invalid currency code. See https://en.wikipedia.org/wiki/ISO_4217. '
'Invalid currency code. See https://en.wikipedia.org/wiki/ISO_4217 . '
'Bonds, testing and precious metals codes are not allowed. '
f"[type=InvalidCurrency, input_value='{forbidden_currency}', input_type=str]"
),
Expand Down

0 comments on commit f27a132

Please sign in to comment.