Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ deprecate semver in favor of semantic_version #209

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

07pepa
Copy link
Contributor

@07pepa 07pepa commented Sep 2, 2024

closes #205 (shedules removal for next magor version so we do not break api contract)

reasons for selecting semantic_version in favor of semver is missing usual

try:
 <import library that does this>
except:
  raise RuntimeError(<here is how you install it>)

TLDR: it requres much more effort

however i folded test from semver to semantic_version and extrended it so it can be just removed on deprecation

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e186814) to head (ca8a8e5).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #209    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           11        17     +6     
  Lines          685      1001   +316     
  Branches       169       244    +75     
==========================================
+ Hits           685      1001   +316     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* fold test from semver to semantic_version so it can just be deleted
* extend test cases
Copy link
Collaborator

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@yezz123 yezz123 changed the title deprecate semver in favor of semantic_version ✨ deprecate semver in favor of semantic_version Sep 2, 2024
@yezz123 yezz123 merged commit 12f3f61 into pydantic:main Sep 2, 2024
20 checks passed
@07pepa 07pepa deleted the close-#205 branch September 3, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate semantic versioning modules
2 participants