Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alias resolution for default settings source. #468

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Fix alias resolution for default settings source. #468

merged 3 commits into from
Nov 6, 2024

Conversation

kschwab
Copy link
Contributor

@kschwab kschwab commented Nov 5, 2024

Fixes #466.

@kschwab kschwab mentioned this pull request Nov 5, 2024
Closed
@hramezani
Copy link
Member

Thanks @kschwab for the PR. Please move the test to test_source_cli.py

@braindevices braindevices mentioned this pull request Nov 5, 2024
Closed
@kschwab
Copy link
Contributor Author

kschwab commented Nov 6, 2024

@hramezani, the issue is independent of the CLI. I removed the CliApp call instead.

@hramezani hramezani enabled auto-merge (squash) November 6, 2024 20:13
@hramezani hramezani merged commit 9583896 into pydantic:main Nov 6, 2024
21 checks passed
@kschwab kschwab deleted the default-settings-source-alias-fix branch November 27, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fail to parse nested model when alias_generator is using
2 participants
@kschwab @hramezani